1.5 night builds: No ethernet adapters avalable in Citrix Hypervisor 8.2 Environment

Bugs
22

I’ve tested updated code and could confirm - it works.
Thanks
When would i expect it in nighty?

23

Hi there
Just curious but https://github.com/vyos/vyos-nightly-build/releases/tag/1.5-rolling-202411200007 still didn’t upgrade configuration correctly.

Something went wrong with ethernet adapters configuration.
Working on earning of error messages

looks like mentioned above solution didn’t implemented.

Either duplex "auto" or speed "auto" in ethernet interface configuration led to configuration error.

However one or both above node could be obsoleted but IMHO there should be some algorithm to safely ignore obsoleted/outdated configuration nodes.
Because you will never know how old was system under upgrade process.

24

Create a bug report on https://vyos.dev
With set of commands to reproduce

25

Hi,

Sorry, haven’t account on https://vyos.dev so you could see error description as below

clean install of Citrix Hypervisor 8.2 VM based on latest 1.5-rolling-202411230007

simplest possible configuration set

vyos@vyos# run show configuration commands
set interfaces ethernet eth0 address 'dhcp'
set interfaces loopback lo
set service ntp allow-client address '127.0.0.0/8'
set service ntp allow-client address '169.254.0.0/16'
set service ntp allow-client address '10.0.0.0/8'
set service ntp allow-client address '172.16.0.0/12'
set service ntp allow-client address '192.168.0.0/16'
set service ntp allow-client address '::1/128'
set service ntp allow-client address 'fe80::/10'
set service ntp allow-client address 'fc00::/7'
set service ntp server time1.vyos.net
set service ntp server time2.vyos.net
set service ntp server time3.vyos.net
set service ssh port '22'
set system config-management commit-revisions '100'
set system console device ttyS0 speed '115200'
set system host-name 'vyos'
set system login user vyos authentication encrypted-password '$6$QxPS.uk6mfo$9QBSo8u1FkH16gMyAVhus6fU3LOzvLR9Z9.82m3tiHFAxTtIkhaZSWssSgzt4v4dGAL8rhVQxTg0oAG9/q11h/'
set system login user vyos authentication plaintext-password ''
set system syslog global facility all level 'info'
set system syslog global facility local7 level 'debug'
[edit]
vyos@vyos#

Everything is working fine.

than new configuration options added

vyos@vyos# set interfaces ethernet eth0 duplex auto
[edit]
vyos@vyos# commit
[ interfaces ethernet eth0 ]
Traceback (most recent call last):
  File "/usr/libexec/vyos/services/vyos-configd", line 137, in run_script
    script.apply(c)
  File "/usr/libexec/vyos//conf_mode/interfaces_ethernet.py", line 338, in apply
    e.update(ethernet)
  File "/usr/lib/python3/dist-packages/vyos/ifconfig/ethernet.py", line 446, in update
    self.set_speed_duplex(speed, duplex)
  File "/usr/lib/python3/dist-packages/vyos/ifconfig/ethernet.py", line 194, in set_speed_duplex
    if not self.ethtool.check_auto_negotiation_supported():
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/vyos/ethtool.py", line 116, in check_auto_negotiation_supported
    return self._base_settings['supports-auto-negotiation']
           ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'supports-auto-negotiation'

[[interfaces ethernet eth0]] failed
Commit failed
[edit]

or

vyos@vyos# set interfaces ethernet eth0 speed auto
[edit]
vyos@vyos# commit
[ interfaces ethernet eth0 ]
Traceback (most recent call last):
  File "/usr/libexec/vyos/services/vyos-configd", line 137, in run_script
    script.apply(c)
  File "/usr/libexec/vyos//conf_mode/interfaces_ethernet.py", line 338, in apply
    e.update(ethernet)
  File "/usr/lib/python3/dist-packages/vyos/ifconfig/ethernet.py", line 446, in update
    self.set_speed_duplex(speed, duplex)
  File "/usr/lib/python3/dist-packages/vyos/ifconfig/ethernet.py", line 194, in set_speed_duplex
    if not self.ethtool.check_auto_negotiation_supported():
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/vyos/ethtool.py", line 116, in check_auto_negotiation_supported
    return self._base_settings['supports-auto-negotiation']
           ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'supports-auto-negotiation'

[[interfaces ethernet eth0]] failed
Commit failed
[edit]
vyos@vyos#

same result during migration from previous image discussed above 1.5-20240916 (latest without problem on Citrix Hypervisor)