That’s good news. I still don’t understand why it was not working before, we are basically doing the same thing. I hope you just had some wrong configuration, but if you had everything right, it would be great if you could find out now what the cause of the problem was so that we can find a fix.
Shaping always works on outbound traffic, so for the upload of LAN clients shaping should be applied to your VyOS’ WAN interface.
Note that, when shaping, it is a good practice to set the maximum bandwidth for the whole link a little bit below the expected maximum, so maybe you could set it to 470mbit instead of the 480mbit I see you got on your test.
Let us know if you need help.