[[nat]] failed when commiting destination NAT

Bugs
#1 
nat {
+    destination {
+        rule 100 {
+            destination {
+                port 22
+            }
+            inbound-interface eth0
+            protocol tcp
+            translation {
+                address 192.168.1.4
+            }
+        }
+    }
source {

Report Time: 2020-12-01 14:32:57
Image Version: VyOS 1.3-rolling-202012010217
Release Train: equuleus

Built by: autobuild@vyos.net
Built on: Tue 01 Dec 2020 02:17 UTC
Build UUID: 51f63067-cf03-4678-ad9b-907ba1b1170f
Build Commit ID: 65ebf0e2c4113c

Architecture: x86_64
Boot via: installed image
System type: KVM guest

Hardware vendor: QEMU
Hardware model: Standard PC (i440FX + PIIX, 1996)
Hardware S/N:
Hardware UUID: 510e9de4-a940-4b9c-b61a-9e996b5c7f67

Traceback (most recent call last):
File “/usr/libexec/vyos/conf_mode/nat.py”, line 199, in
verify©
File “/usr/libexec/vyos/conf_mode/nat.py”, line 133, in verify
if nat[‘helper_functions’]:
KeyError: ‘helper_functions’

[[nat]] failed
Commit failed

#2

Hello @arfbarky, does not possible to reproduce this issue. Can you describe reproducing steps in detailed? I successfully use the following rules:
set nat destination rule 100 destination port ‘22’
set nat destination rule 100 inbound-interface ‘eth0’
set nat destination rule 100 protocol ‘tcp’
set nat destination rule 100 translation address ‘192.168.1.4’

UPD:// I can confirm. Need to have at least one NAT source rule for reproducing this issue

#3

Well, I have a committed config with no destination NAT, only a single source NAT:

nat {
    source {
        rule 100 {
            outbound-interface eth0
            translation {
                address masquerade
            }
        }
    }
}

I hand type those destination NAT lines and commit, and I get the error. That’s all I know.

I have the exact same config in another system with version VyOS 1.3-rolling-202011190217 and it works fine. This is a fresh install in a Proxmox VM.

#4

It seems issue from 28 of November related with this patch https://github.com/vyos/vyos-1x/commit/e4ea410b7587b0018055962c295ab491133f458c#diff-73b0ee812456b3cb072d98d47135c69929642c2a72b52712fb1c130f14439732

@arfbarky do you have a chance to create a bug report on the https://phabricator.vyos.net/ ?

#5

I am happy to do so, I have never done one before … what information is needed?

#6

Register on phabricator, create a bug report with described reproducing steps. Thanks!

#7

Will do, thank you very much!

#8

I seem to know what the problem is, please create a bug report at https://phabricator.vyos.net

Once there is a bug report, the community can consider fixing it

Just add a small judgment to get_config and verify

#9

Hi @jack9603301 will be fixed in tomorrows rolling.
Bug report https://phabricator.vyos.net/T3102

#10

Seems to have been fixed