image build was failing. Looking at the diff between current commit and 1.4.0-epa1 (that built fine) it appears the command “os.chdir(defaults.BUILD_DIR)” is executed twice in short succession. I commented out the 2nd command (line 365) and it built successfully.
kyle
February 26, 2024, 1:18am
2
Probably related to this.
vyos:sagitta ← hcuk94:sagitta
opened 02:57PM - 25 Feb 24 UTC
## Change Summary
In a recent commit #273d624 the build-vyos-image script was m… odified but lines 334-339 were identical to lines 361-366, which is causing the build to fail with the following error:
> Traceback (most recent call last):
> File "/__w/vyos-build/vyos-build/vyos-build/./build-vyos-image", line 366, in <module>
> os.chdir(defaults.BUILD_DIR)
> FileNotFoundError: [Errno 2] No such file or directory: 'build'
> Error: Process completed with exit code 1.
Essentially the script will attempt twice to chdir to 'build' which succeeds the first time but fails the 2nd as it is already in the build directory.
This commit removes the duplicated lines so that the build can succeed.
## Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes)
- [ ] Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
- [ ] Other (please describe):
## Related Task(s)
* https://vyos.dev/T6065
## Component(s) name
Build script
## Proposed changes
Remove duplicate lines only.
## How to test
Re-run build script and it will no longer error.
## Checklist:
- [x] I have read the [**CONTRIBUTING**](https://github.com/vyos/vyos-1x/blob/current/CONTRIBUTING.md) document
- [x] I have linked this PR to one or more Phabricator Task(s)
- [x] My commit headlines contain a valid Task id
- [ ] My change requires a change to the documentation
- [ ] I have updated the documentation accordingly
yup, that looks like it. Didn’t check there to see if it was reported.
system
March 27, 2024, 1:36am
4
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.