DHCP overlap error message is printed incorrectly

[ramblurr]

I was configuring DHCP on my router (running saggita rolling, built yesterday) and got this message:

This looks suspiciously like python f-strings.

Sure enough, line 250 of dhcp_server.py is missing the f before the string:

https://github.com/vyos/vyos-1x/blob/current/src/conf_mode/dhcp_server.py#L250

[a.hajiyev]

Hi @ramblurr which rolling release are you using?

[a.hajiyev]

Can you please share your configuration?

[ramblurr]

Hi @a.hajiyev

@a.hajiyev

Hi @ramblurr which rolling release are you using?

@ramblurr

I was configuring DHCP on my router (running saggita rolling, built yesterday)…

As for the config, I don’t have it anymore, but it was something simple where a shared-network-name subnet overlapped with another one.

This isn’t a support request, but a bug report. I linked exactly to the code that needs fixing so that vyos gives the right error message.

[n.fort]

Thanks! New bug report created: ⚓ T5105 DHCP Server - Wrong error message

[ramblurr]

Thanks @n.fort . In the future should I submit bug reports directly to the tracker or here on the forum?

[n.fort]

Always better to submit bug reports and feature request in vyos.dev.
PR are only merged if they are linked to a task in vyos.dev