DHCP overlap error message is printed incorrectly

ramblurr · March 21, 2023, 12:02pm

I was configuring DHCP on my router (running saggita rolling, built yesterday) and got this message:

This looks suspiciously like python f-strings.

Sure enough, line 250 of dhcp_server.py is missing the f before the string:

vyos/vyos-1x/blob/current/src/conf_mode/dhcp_server.py#L250


      
                  net = ip_network(subnet)
                  for n in subnets:
                      net2 = ip_network(n)
                      if (net != net2):
                          if net.overlaps(net2):
                              raise ConfigError(f'Conflicting subnet ranges: "{net}" overlaps "{net2}"!')
          
          
# Prevent 'disable' for shared-network if only one network is configured
          if (shared_networks - disabled_shared_networks) < 1:
              raise ConfigError(f'At least one shared network must be active!')
          
          
if 'failover' in dhcp:
              if not failover_ok:
                  raise ConfigError('DHCP failover must be enabled for at least one subnet!')
          
          
    for key in ['name', 'remote', 'source_address', 'status']:
                  if key not in dhcp['failover']:
                      tmp = key.replace('_', '-')
                      raise ConfigError(f'DHCP failover requires "{tmp}" to be specified!')
          
          
for address in (dict_search('listen_address', dhcp) or []):

a.hajiyev · March 22, 2023, 5:57am

Hi @ramblurr which rolling release are you using?

a.hajiyev · March 22, 2023, 6:23am

Can you please share your configuration?

ramblurr · March 22, 2023, 7:15am

Hi @a.hajiyev

As for the config, I don’t have it anymore, but it was something simple where a shared-network-name subnet overlapped with another one.

This isn’t a support request, but a bug report. I linked exactly to the code that needs fixing so that vyos gives the right error message.

n.fort · March 22, 2023, 10:33am

Thanks! New bug report created: ⚓ T5105 DHCP Server - Wrong error message

ramblurr · March 22, 2023, 11:02am

Thanks @n.fort . In the future should I submit bug reports directly to the tracker or here on the forum?

n.fort · March 22, 2023, 11:04am

Always better to submit bug reports and feature request in vyos.dev.
PR are only merged if they are linked to a task in vyos.dev

system · March 24, 2023, 11:04am

This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.