Mostly posting in case this is helpful for others, but also as a feature request.
Namely set service pppoe-server ppp-options disable-ccp should be set by default when VyOS is configured as a PPPoE server.
A fresh install of any version of VyOS that uses Accel-ppp does not have ppp-options disable-ccp set. As a result pppoe clients have slow download since the compression algorithm is a bottleneck.
Earlier versions of VyOS did not support ppp-options disable-ccp and set the ccp=0 in /run/accel-pppd/pppoe.conf which disables ppp client compression
When upgrading a VyOS server operating as a PPPoE server from 1.3.x to a newer version running accel-ppp things work as expected. The accel-ppp setting ccp=o is maintained.
However, when installing a fresh version of VyOS, at least the latest Stream version, the config does not have ppp-options disable-ccp set. This means that /run/accel-pppd/pppoe.conf has ccp=1, meaning client compression is enabled and the clients have slow downloads.
While writing this it occurred to me that is probably makes more sense to have ccp=0 as the default and to change the config syntax to:
set service pppoe-server ppp-options enable-ccp
Which would set ccp=1 in /run/accel-pppd/pppoe.conf.
Best
Mark
ps: with the latest Stream version, the server has to be rebooted before ppp-options disable-ccp takes affect.
How did you measure that the downloads went slow?
Im thinking if something like LZ4 is being used it should be fast and improving download speeds for not already compressed data (regular html and such) unless you have way to little hardware resources configured for your VyOS box?
But at the same time I kind of agree with you. Having compression enabled by default (for routed traffic) makes sense for a phonemodem or satellite setup (were basically every bit counts) while PPPoE is often used for DSL and similar which operates in the Mbps range (or higher) and not kbps range so then trying to compress data (which often is already compressed) will be a waste of resources at the VyOS router - better to spend those CPU cycles to actually forward packets as-is.
Ran iperf3 as the server on the Vyos box and on a laptop as the iperf3 client. We saw similar results (good upload, slow download) when using speedtest.net when we initially deployed the box.
Upload speed were good (1G), but the download (to the laptop) speed topped out around 150 Mbps.
Initially I did not suspect pppoe but when I eliminated pppoe the results were fine.
Since I had a faint memory of VyOS switching to Accel-ppp at some point I loaded a test machine with 1.3.8 and ran tests upgrading until I got to the latest Stream version. This process only provided good results.
So I ended up diff’ing pppoe.conf from the upgraded box and from a box with a fresh install of the latest Stream version. At this point I discovered the difference in the ccp setting in pppoe.conf.
The box has a Intel N305. We have another installation that is still running 1.3.8 and has had zero issues using a Xeon D-1528. I was really surprised when we deployed the N305 box and immediately ran into problems. Initially thought I had a MTU problem… so spent a bunch of time with Wireshark…