PPPoE adjust-mss issue

Bugs
1

On the newer rolling releases adjust-mss is broken on pppoe.

set interfaces pppoe pppoe0 ip 
Possible completions:
   adjust-mss           Adjust TCP MSS value
   disable-forwarding   Disable IP forwarding on this interface
   source-validation    Source validation by reversed path (RFC3704)

set interfaces pppoe pppoe0 ip adjust-mss 1452

While committing this results in an error:

Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/interfaces-pppoe.py", line 134, in <module>
    apply(c)
  File "/usr/libexec/vyos/conf_mode/interfaces-pppoe.py", line 125, in apply
    p.update(pppoe)
  File "/usr/lib/python3/dist-packages/vyos/ifconfig/pppoe.py", line 129, in update
    self.set_dhcpv6(True)
  File "/usr/lib/python3/dist-packages/vyos/ifconfig/interface.py", line 1292, in set_dhcpv6
    render(config_file, 'dhcp-client/ipv6.j2', self._config)
  File "/usr/lib/python3/dist-packages/vyos/template.py", line 141, in render
    rendered = render_to_string(template, content, formater, location)
  File "/usr/lib/python3/dist-packages/vyos/template.py", line 110, in render_to_string
    rendered = template.render(content)
  File "/usr/lib/python3/dist-packages/jinja2/environment.py", line 1090, in render
    self.environment.handle_exception()
  File "/usr/lib/python3/dist-packages/jinja2/environment.py", line 832, in handle_exception
    reraise(*rewrite_traceback_stack(source=source))
  File "/usr/lib/python3/dist-packages/jinja2/_compat.py", line 28, in reraise
    raise value.with_traceback(tb)
  File "/usr/share/vyos/templates/dhcp-client/ipv6.j2", line 43, in top-level template code
    {%         for interface, interface_config in pd_config.interface.items() if pd_config.interface is vyos_defined %}
jinja2.exceptions.UndefinedError: 'dict object' has no attribute 'interface'


**[[interfaces pppoe pppoe0]] failed**
2

EDIT: This is bad advice, see @c-po below
Instead of setting it there, what happens if you set it at the firewall level?

set firewall options interface pppoe0 adjust-mss 1452

Regardless I’d say you’ve hit a small bug :slight_smile:

3

@tjh that option is deprecated - VyOS 1.4 moved it to the interface level

1 Like
4

@AWHarvard thanks for this report. The issue has been fixed and will be in the next rolling release.

1 Like