Redistribute Table for bgp not working

Bugs
1

The following configuration creates an invalid FRR configuration:

 set  protocols bgp address-family ipv4-unicast redistribute table 239

FRR:

address-family ipv4 unicast
  redistribute table 
 exit-address-family

I tracked it down to bgpd.frr.j2: (vyos-1x/data/templates/frr/bgpd.frr.j2 at fba59f9e19679764e41cde045fb572291e9fb25f · vyos/vyos-1x · GitHub)

  redistribute table {{ protocol_config.table }}

I don’t know the data structure behind it, but changing it to {{ protocol_config }} actually fixed the output to:

address-family ipv4 unicast
  redistribute table 239
 exit-address-family

so it seems .table in this case is wrong (or the code that creates this item is wrong)

Edit: I also believe this should use “redistribute table-direct 239” instead of “redistribute table 239” otherwise also the ip import-table 239 command needs to be added.

2

Thank you for reporting this ancient bug.

It will be handled via ⚓ T7161 bgp: can not redistribute optional routing table

3

I also found that metric and route-map options are missing completely

Could those be added as well?

I have added some local changes for this already, I’m not clear yet how the configuration is actually made available (i.e. why .table is wrong, and if I added .route-map / .metric if they would be available)

4

route-map and metric options will be added to rolling and stream first as a configuration migration is required for this. Tracked via ⚓ T7163 bgp: add CLI route-map and metric support for "redistribute table"

5

GitHub PRs: