Hi, VyOS Team.
I want to ask you do you have a system architect of project? Why I ask you. That is because I don’t see uniform approach to development.
When we configure ISIS the commands specific for interface configures inside ISIS branch configuration (in the manner of Juniper)
set protocols isis <name> interface <interface> hello-interval <seconds>
But the same configuration for OSPF performs inside interface configuration mode (in the manner of Cisco).
set interfaces ethernet <interface> ip ospf hello-interval <seconds>
And the same for RIP. Such things don’t seem critical. But it’s all a little bit confusing.
I think if you chose the Juniper-like CLI so you should follow this way. And all routing protocols commands specific for interface must be configured in protocol config mode.
The second example: I came across maniphest T2019.
I disagree with one of the statements declared in the maniphest what did I say there. I think it is not a bug but feature. And I’ve substantiated my opinion. But I did it late and the behavior has already changed. So what will you do in this situation? Will you back the behavior or leave it as it is? And who will decide it?
Openness to suggestions is a good thing. But not all wishes should be implemented because not all of them are reasonable as in this case.
I understand that this is an open-source project. Maybe I’m too nitpick. But these little things form the attitude to the project in the end. Especially since you have a commercial component.
It may seem that I’m scolding you. But this is not the case. I say this all because I want the project to be even more successful. And I really appreciate what you’re doing.