Vya_config_commit-confirm not a valid identifier

[UnixSH]

Hi !

I’m trying to understand why I’m not able anymore to use my script in /config/scripts/vyos-postconfig-bootup.script

I was running before on a 1.3 rolling from 2023.03.05, everything was fine.
Now I’m running a rolling from yesterday, and the error I get from the console is “vyatta_config_commit-confirm not a valid identifier”, blocking my script to work properly.
The error seems to come from the first line ‘source /opt/vyatta/etc/functions/script-template’, since I tried to just put this line into the script.

Could someone help here ?

Thanks’.

[n.fort]

Can you post the content of the script?

[UnixSH]

sure.

cat /config/scripts/vyos-postconfig-bootup.script

#!/bin/sh

source /opt/vyatta/etc/functions/script-template
#configure
#delete service ssh listen-address x.x.x.x
#commit
#set service ssh listen-address x.x.x.x
#commit
#exit

[echowings]

Hi UnixSH,
Try this

# Create script
tee  /config/set_ssh_listen_address.sh << "EOF"
#!/bin/sh
source /opt/vyatta/etc/functions/script-template
configure
delete service ssh listen-address 0.0.0.0
commit
set service ssh listen-address 192.168.11.1
commit
exit
EOF

Then add the script to running in the vyos-postconfig-bootup.script

tee >> /config/scripts/vyos-postconfig-bootup.script << "EOF"
sudo bash /config/set_ssh_listen_address.sh
EOF

[Apachez]

Instead of

#!/bin/sh

then

#!/bin/vbash

can be used in /config/set_ssh_listen_address.sh

[UnixSH]

Hi both, many thank’s for you replies.

I tried both of your method, and :

1. calling another script from vyos-postconfig-bootup.script is working
2. changing the shebang to vbash is also working

Any clue on why I got this error initially, and why we could do that to get around it ?
That should need a fix if I get that on a fresh install, right ?

[Apachez]

My guess is that the script-template in order to use vyos op-mode and conf-mode commands from within a script is based on using /bin/vbash instead of /bin/sh.

So if you either call a separate script from the pre/postconfig-script OR alter the pre/postconfig-script to use #!/bin/vbash instead of #!/bin/sh the issue will get resolved.

Personally I would create a custom script in /config/custom/filename.sh (which starts with a #!/bin/vbash) and call that from the pre/postconfig-script (who remains using #!/bin/sh).