In VyOS “hw-id” is used to hook each VyOS interface to the physical interfaces of the host (or if runned as VM guest what the host exposes to the VM guest as virtual nics).
hw-id is the real mac-address of the physical (or virtual) nic.
Example:
set interfaces ethernet eth0 hw-id 'aa:bb:cc:dd:ee:ff'
So verify how your VMware is configured regarding the VyOS VM guest.
If virtual nic is used then the mac-address the VyOS see should be unchanged when you upgrade VMware or replace hardware the VMware host runs at.
But if you do stuff like pass-through or expose the host adapter to the VM guest then if the physical nic is replaced (or you move to a new VM host) the hw-id in VyOS will no longer match and you need to update that.
This is to be expected when upgrading the “hardware” version in VMWare: new NIC “hardware” is installed into the VM and VyOS loses the MAC-interface association set through the hw-id config option, just as Apachez pointed out.
To set a static MAC for your VM, please refer to MAC Address Management. This is not a guarantee though: upgrading VM hardware version is always a tricky operation.